Remove special text selection behavior of install command#2282
Merged
Manishearth merged 1 commit intomainfrom Apr 11, 2026
Merged
Remove special text selection behavior of install command#2282Manishearth merged 1 commit intomainfrom
Manishearth merged 1 commit intomainfrom
Conversation
This reverts commit c7a310c. Now that there is a copy button, there is no need for special selection behavior anymore.
Manishearth
approved these changes
Apr 11, 2026
Member
|
Actually, it's probably fine to keep both, some people will trust the visual more than a copy button |
Contributor
Author
|
One downside of the select all behavior is that it's not possible to copy part of the install command anymore. For example, someone might just want to read the install script or redirect it into a file before executing, instead of piping directly into a shell. This is a bit annoying at the moment. It's also pretty easy to select everything with a triple click, for manually copying. |
Member
|
Ah good point! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit c7a310c.
Now that there is a copy button, there is no need for special selection behavior anymore.